Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ov_eval documentation typo #333

Closed
AZdet opened this issue May 2, 2023 · 0 comments · Fixed by #337
Closed

ov_eval documentation typo #333

AZdet opened this issue May 2, 2023 · 0 comments · Fixed by #337
Labels
bug Something isn't working

Comments

@AZdet
Copy link

AZdet commented May 2, 2023

Thanks for your great work! While using the ov_eval tool, I found two typos in the documentation page.

  1. In transformation section, rosrun ov_eval format_convert folder/path/ should be rosrun ov_eval format_converter folder/path/ instead, as the executable name is format_converter.
  2. In plot trajectory section, the order of the order of the gt file and prediction files are flipped in the command template and example command

rosrun ov_eval plot_trajectories <align_mode> <file_gt.txt> ... <file_est9.txt>
rosrun ov_eval plot_trajectories posyaw 1565371553_estimate.txt truths/V1_01_easy.txt

From the code, the command template order is correct (i.e. gt should be the first file).

I'd appreciate it if you could look into them and confirm these are indeed typos. Since the docs folder is not source controlled, I guess it is better to leave them for you to fix (if ever needed), but I am happy to help.

@goldbattle goldbattle added the bug Something isn't working label May 4, 2023
goldbattle added a commit that referenced this issue May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants