Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Customization options added to long text field #821

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

RajGM
Copy link
Contributor

@RajGM RajGM commented Sep 17, 2022

Signed-off-by: Raj Gaurav Maurya rajgmsocial19@gmail.com

harinij and others added 3 commits August 19, 2022 15:32
@RajGM
Copy link
Contributor Author

RajGM commented Sep 18, 2022

@htuerker @harinij

@harinij
Copy link
Member

harinij commented Sep 21, 2022

@RajGM PR needs to be submitted to the develop branch.

@harinij harinij changed the base branch from main to develop September 21, 2022 06:31
@RajGM
Copy link
Contributor Author

RajGM commented Sep 21, 2022

Got it.

@notsidney
Copy link
Contributor

This PR only adds the text fields to save the custom regex and character limit to the column config. It neither validates the regex nor implements the limit on Long Text fields. @harinij is that within the scope of the original issue (#718)?

@vercel
Copy link

vercel bot commented Oct 2, 2022

@RajGM is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@RajGM
Copy link
Contributor Author

RajGM commented Oct 2, 2022

Hi @notsidney
It's working for me.
The number of characters can't be more than the max limit.
Inputs can be multiline.
Regex validation is working as well.

LongWorking

LongWorking2

@RajGM
Copy link
Contributor Author

RajGM commented Oct 2, 2022

I faced the same problem of changes not working.
But when I restarted the server manually, it worked.

@notsidney
Copy link
Contributor

Thanks. I’m merging this as part of the next release 🚀

@notsidney notsidney merged commit c158adb into rowyio:develop Oct 3, 2022
@RajGM
Copy link
Contributor Author

RajGM commented Oct 3, 2022

Most welcome, Sidney.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants