Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added tooltip to buttons #1430

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

janvi01
Copy link
Contributor

@janvi01 janvi01 commented Oct 2, 2023

Fixes #1411

Added tooltips to various buttons.

Screenshot -

Screenshot 2023-10-02 at 12 13 32 PM

P.S. - I noticed most of the buttons on the Rowy web app are without tooltips. I can update them in this PR.

We can classify where we need tooltips depending on the button.

  1. If the button is too obvious, I don't think a tooltip is necessary.
  2. If the button is to clarify an immediate operation, a tooltip can be useful.

What do you say? @harinij

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
rowy-typedoc ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 6:43am

@vercel
Copy link

vercel bot commented Oct 2, 2023

@janvi01 is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@shamsmosowi shamsmosowi changed the base branch from main to develop October 25, 2023 07:42
@shamsmosowi shamsmosowi merged commit fd8df49 into rowyio:develop Oct 25, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No tooltips showing for Table settings header buttons
2 participants