-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for bulk deletion of rows #1291
Merged
Merged
Commits on Aug 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 17369b4 - Browse repository at this point
Copy the full SHA 17369b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ca59c8 - Browse repository at this point
Copy the full SHA 9ca59c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for febe46c - Browse repository at this point
Copy the full SHA febe46cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b5c2e3 - Browse repository at this point
Copy the full SHA 9b5c2e3View commit details -
disable row selection for array sub table page
Row selection has been disabled because bulk delete functionality cannot work for array sub table according to the current implementation. Bulk delete problem: Suppose we have an array with values `[a, b, c]`. Suppose, the indexes to be removed are [1, 2]. The UI asks firebase function to remove index 1. After 1, the UI asks index 2 to be deleted but index 2 doesn't exist. After deletion of index 1, the array is `[a, c]`.
Configuration menu - View commit details
-
Copy full SHA for 3d45e34 - Browse repository at this point
Copy the full SHA 3d45e34View commit details -
make
enableRowSelection
optional and false by default`enableRowSelection` was introduced in the last commit. As of this commit row selection is enabled for TablePage and SubTablePage.
Configuration menu - View commit details
-
Copy full SHA for 3223ae9 - Browse repository at this point
Copy the full SHA 3223ae9View commit details
Commits on Aug 23, 2023
-
change logic to determine state of checkbox in header row
If there are 1000 rows and we have rendered 100 then select all will only select 100. In this case, technically all rows in react-table are selected but we should not show the checked state. It leads to bad UX. Indermediate would be better. Also, split the additions of row selection column into a new useMemo. This ensures that if a row is selected we are only re-calculating the row selection column and not all.
Configuration menu - View commit details
-
Copy full SHA for f087105 - Browse repository at this point
Copy the full SHA f087105View commit details -
fix css of CheckboxIndeterminateIcon
Due to wrong CSS we were not able to see the icon.
Configuration menu - View commit details
-
Copy full SHA for 5936f13 - Browse repository at this point
Copy the full SHA 5936f13View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.