Render each mime-part into an individual iframe #9519
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabzm
force-pushed
the
message-render-iframe
branch
2 times, most recently
from
ba35bc4
to
2804d9d
Compare
pabzm
force-pushed
the
message-render-iframe
branch
from
2804d9d
to
d6a17b3
Compare
pabzm
force-pushed
the
message-render-iframe
branch
from
d6a17b3
to
b3ff9c8
Compare
pabzm
force-pushed
the
message-render-iframe
branch
7 times, most recently
from
3a8353c
to
edf0cc8
Compare
pabzm
changed the title
pabzm
changed the title
|
@alecpl I didn't find any problems, but still want to check some more plugins. Also one test is missing. But I think the general approach won't change anymore, so a review would already make sense. |
|
@alecpl Do you think we should keep "larry" working for future releases? I'm not sure yet how much work it would be to make larry fit for this change, but before I even try I want to be sure that you consider it necessary. (I would deprecate it and keep it maintained for v1.6.x, but not later versions.) |
pabzm
force-pushed
the
message-render-iframe
branch
3 times, most recently
from
7e519b5
to
0f5f90d
Compare
|
I'm finished with cleaning the commit history now. |
This allows for a little cleaner code
This probably wasn't implemented previously because HTML-parts usually didn't run through get.php.
That way it's testable.
Meta refresh would require unsafe-inline in a CSP, which we want to avoid.
pabzm
force-pushed
the
message-render-iframe
branch
from
0f5f90d
to
3d8b8d3
Compare
|
(Rebased to latest of "master".) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #9465
TODO: