Notification focus on click in Chrome #9467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DannyDaemonic Thank you for the contribution! Did you by chance test this change on other OS like Linux or macos? I'm wondering how this behaves on those. |
|
I tested it with Firefox on Linux and no issues there. I just installed Chrome and can confirm the same issue exists under the Linux builds of Chrome and the same Unfortunately, I don't currently have an easy way to test this on macOS. |
pabzm
approved these changes
May 30, 2024
alecpl
added
bug
C: User Interface
C: Plugins
4. to release
and removed
3. to review
labels
alecpl
pushed a commit
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Windows, it seems at some point Chrome stopped focusing on the window/tab that sent the notification when you click it. Firefox still behaves correctly, but to get this to work again for Chrome, I had to call
window.parent.focus().Edit: I did test this change in other browsers. This fixes the same issue in Edge (because it's basically just Chrome now) and it doesn't break anything in Firefox.