Improve the notification sound. #8155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The old sound doesn't fit the role of a notification very well. The current sound is more befitting to the objective of notify the user and brings a simple and modern semblance to the project. Signed-off-by: Renan Andrade Torrente <renan.torrente@hotmail.com> Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
Yes, we cut the .mp3 and .wav to 1/6 and 1/4 of the original size, respectively.
The sounds were created by the Renan Andrade Torrente, one of the signers off. The license (at
Do you think anything else is necessary? |
alecpl
pushed a commit
that referenced
this pull request
Aug 4, 2021
The old sound doesn't fit the role of a notification very well. The current sound is more befitting to the objective of notify the user and brings a simple and modern semblance to the project. Signed-off-by: Renan Andrade Torrente <renan.torrente@hotmail.com> Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old sound doesn't fit the role of a notification very well.
The current sound is more befitting to the objective of notify the user
and brings a simple and modern semblance to the notication sound.
Signed-off-by: Renan Andrade Torrente renan.torrente@hotmail.com
Signed-off-by: Igor Matheus Andrade Torrente igormtorrente@gmail.com