Fix dovecot passwdfile change #8145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to change the password.
…rd_dovecotpw_with_method' is set to true (escaping the {METHOD} in the passwd file)
|
I think it will be better to log the error and stop execution from inside the hash_password() method. This way it will be working for any driver that uses it. |
alecpl
added a commit
that referenced
this pull request
Aug 1, 2021
alecpl
pushed a commit
that referenced
this pull request
Aug 1, 2021
* Fix dovecot passwd-file handler
* Set new password hash correctly
* If password hashing failes during password change request, abort trying to change the password.
* Escaping hashed password is not needed and actually breaks if 'password_dovecotpw_with_method' is set to true (escaping the {METHOD} in the passwd file)
alecpl
added a commit
that referenced
this pull request
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a few problems with the dovecot_passwdfile password-driver.
$handleand$newhash- introduced in commitca523bd7facf29aaabf08718252314fca05c83a5)password::hash_password-function returns false (which could happen when usingdovecotaspassword_algorithm), the code would still proceed to change the password to an empty string even though hashing failed. It now raises an error instead.\{SSHA256\}...Let me know if something needs to be changed.
Thanks for developing an awesome mail client!