-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elastic: make custom less files optional #7497
Conversation
|
This is trivial but the current version of cssshrink.sh does not work with Elastic because Elastic CSS is in the styles folder not the root of the skin. to fix you plugin error try running minifying test on styles.css: |
OK. We can use clean-css, but please describe installation of less and clean-css in the README. We also have to install proper version for Travis. |
I have added a little more detail to the note in the readme file. do you think it is enough? But I'm stumped by Travis, may be this change has to wait until the Travis tests can be moved to a more modern distro, it looks like Ubuntu Trust has a very old node-less package. |
Instead of installing the node-less package we could just run: That note should be enough. |
Thanks for the tip, that did the trick. I left out the clean-css plugin because the Travis script does not minify the css. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove these .dist files and add a note to README.
Optional
@imports
where added in Less v2 which was released 5 years ago. So by bumping the min version up from 1 to 2 (v3 is already used in jsdeps) then the customisation files_styles
and_variables
can be renamed as dist files so they don't conflict with what people might have in their local repos.the
-x
compression option does not work properly in current version of lessc so I have also update the readme to mention the clean-css plugin and changed the extension of the generated files to.min.css
so that cssshrink.sh skips the already minified files.