allow array in smtp_host config #7296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually it is mentioned in "Leave blank to show a textbox at login, give a list of hosts to display a pulldown menu or set one host as string.". I'd like to have the array option mentioned in defaults.inc.php. Other than that it looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is possible to configure an array of imap hosts but not smtp hosts so if not all your providers use the same naming conventions for their servers you can configure the imap but the smtp.
inspired by https://www.roundcubeforum.net/index.php/topic,28819.msg73532.html#msg73532
if this is accepted I'll update the config information in the wiki to include the array option, similar to what is there for the default_host option - i did not update the comments in
defaults.inc.phpbecause there is nothing there about the array option for the imap so I think the wiki is enough.I've also fixed a bug in the installer which meant that the
%hmacro ofsmtp_serverwas never expanded and always returned blank.