managesieve vacation doesn't use CRLF correctly

[LunarLambda]

Prerequisites

• I have searched for duplicate or closed issues
• I can recreate the issue with all plugins disabled

Describe the issue

We are having an issue where the body of vacation messages set with managesieve-vacation uses LF instead of CRLF, causing receiving mail clients to see the entire body written as a single line.

The same does not happen with the managesieve "out of office" filter.

I tracked the issue down to this line in rcube_sieve_vacation.php. Changing it to remove the str_replace call makes the message send correctly, and the sieve script stored on the server then has correct CRLF for the whole file.

I'm unsure whether this is a bug with our setup/configuration or with managesieve itself, since the "out of office" filter works and vacation one doesn't.

What browser(s) are you seeing the problem on?

Firefox

What version of PHP are you using?

8.2

What version of Roundcube are you using?

1.6.5

JavaScript errors

N/A

PHP errors

N/A

[alecpl]

For me multi-line text is inserted into the script with LF only, in both places. According to https://datatracker.ietf.org/doc/html/rfc5228#section-2.1 "CR and LF can only appear as the CRLF line ending". So, it looks that we have to make sure to use CRLF everywhere and this is indeed a bug.

[alecpl]

Fixed.