Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP password is changed incorrectly if it contains %p #8435

Closed
aalonzi opened this issue Feb 4, 2022 · 2 comments
Closed

SMTP password is changed incorrectly if it contains %p #8435

aalonzi opened this issue Feb 4, 2022 · 2 comments
Milestone

Comments

@aalonzi
Copy link

aalonzi commented Feb 4, 2022

On one of the email boxes I encountered the following error while trying to send, only from roundcube:
535 5.7.8 Error: authentication failed

After some tests I realized that the password sent to the server for authentication was not actually that of the box, that is, let's assume a password like:
abcd%p
was replaced with:
abcdabcd%p

this happens on line 176 of "program / lib / Roundcube / rcube_smtp.php":
$smtp_pass = str_replace ('%p', $ rcube-> get_user_password(), $ CONFIG['smtp_pass']);

Does it happen to others too?

@alecpl
Copy link
Member

alecpl commented Feb 4, 2022

Yes. %p is a special template. I guess we should replace it only if smtp_pass='%p'. So, it is a bug.

@alecpl
Copy link
Member

alecpl commented Mar 13, 2022

Fixed. As it is a minimal BC break I don't plan to backport this to 1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants