Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGP-signed HTML emails aren't detected as HTML during reply/forward #8405

Closed
rimas-kudelis opened this issue Jan 18, 2022 · 5 comments
Closed

PGP-signed HTML emails aren't detected as HTML during reply/forward #8405

rimas-kudelis opened this issue Jan 18, 2022 · 5 comments
Labels
bug C: MIME parsing C: Plugins
Milestone
1.6-beta

Comments

@rimas-kudelis
Copy link
Contributor

rimas-kudelis commented Jan 18, 2022 •
edited
Loading

I have Roundcube 1.5.0 running, and I configured it so that by default only replies and forwards of HTML messages are composed as HTML.

This works just fine for stuff like Netflix newsletters, however, when I received an OpenPGP-signed HTML email today and wanted to forward it inline or reply to it, Roundcube just kept opening the plain text editor instead of the rich text one.

The email in question was sent using Thunderbird 91.5.0 and is structured like this:

  • multipart/signed
    • multipart/mixed
      • multipart/alternative
        • text/plain
        • multipart/related
          • text/html
          • image/png
    • application/pgp-signature
@rimas-kudelis rimas-kudelis mentioned this issue Jan 18, 2022
Closed
@rimas-kudelis rimas-kudelis changed the title PHP-signed emails aren't detected as HTML during reply/forward, even if they are multipart/mixed inside with a text/html part PHP-signed HTML emails aren't detected as HTML during reply/forward Jan 18, 2022
@rimas-kudelis rimas-kudelis changed the title PHP-signed HTML emails aren't detected as HTML during reply/forward PGP-signed HTML emails aren't detected as HTML during reply/forward Jan 18, 2022
@alecpl
Copy link
Member

alecpl commented Jan 22, 2022

I'm unable to reproduce. Could you provide a sample message?

@alecpl
Copy link
Member

alecpl commented Jan 22, 2022

I was able to reproduce with the following structure:

- multipart/signed
    - multipart/mixed
        -  multipart/related
            - text/html
            - image/png
    - application/pgp-signature

@alecpl alecpl added this to the later milestone Jan 22, 2022
alecpl added a commit that referenced this issue Jan 22, 2022
@alecpl
Fix setting HTML mode on reply/forward of a signed message (#8405)
f546d72
@alecpl
Copy link
Member

alecpl commented Jan 22, 2022

f546d72 fixes the issue for my case. Let me know if it fixes it for your, please.

@rimas-kudelis
Copy link
Contributor Author

Thanks! Not sure if I'll test the fix before the release though.

alecpl added a commit that referenced this issue Jan 30, 2022
@alecpl
Fix setting HTML mode on reply/forward of a signed message (#8405)
e38d4e1 
Simplify and unify has_html_part() and has_text_part() methods.
alecpl added a commit that referenced this issue Jan 30, 2022
@alecpl
Fix setting HTML mode on reply/forward of a signed message (#8405)
5bcb762
alecpl added a commit that referenced this issue Jan 30, 2022
@alecpl
Fix setting HTML mode on reply/forward of a signed message (#8405)
b66bbf2 
Simplify and unify has_html_part() and has_text_part() methods.
@alecpl alecpl modified the milestones: later, 1.6-beta Jan 30, 2022
@alecpl
Copy link
Member

alecpl commented Jan 30, 2022

One more commit was needed, but it's fixed now.

@alecpl alecpl closed this as completed Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: MIME parsing C: Plugins
Projects
None yet
Milestone
1.6-beta
Development

No branches or pull requests
2 participants
@alecpl @rimas-kudelis