-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link reference holds wrong URL #8021
Comments
I'm seeing kinda different issue. Could you provide precise steps to reproduce? |
Expected behavior: Actual behavior: |
All right. That's one thing. Thanks. The other thing might be how to prevent that happening when such a content is being created, if it was created by Roundcube. |
Honestly, I created this issue with my user experience in mind (without research how markdown renderers deal with this situation). I am fully aware that others might argue that re-using reference ids is illegal or that one might want to re-use a reference from the quoted text, but I prefer the other use case:
I do not see an issue in the editor (but I haven't played with it). |
Fixed. |
The fix didn't work on PHP < 7.4. Reverted. I'll look for a different solution. |
… text message (#8021) Second attempt that should work on all supported PHP versions
Fixed. |
My provider has Roundcube Webmail 1.4.11. Roundcube or one of the plugins renders references to links as link, i.e. in
see [1]
the number would become clickable with the URL that is given near the end of the email[1] https://example.com
.Given a plain-text email with such reference(s) was replied with more text and more references (i.e. the reply contains
see my link [1]
), then thehref
of this number holds the URL of the quoted email.In the example below, both references
[1]
point to https://example.com. The best fix would find references per quoted email (level of quotation), but imho, it is acceptable to just get the actual email right and fully ignore the quoted one(s).Content-Type: text/plain; charset=UTF-8; format=flowed
The text was updated successfully, but these errors were encountered: