Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managesieve vacation: UI should allow display names in from field #6760

Closed
c0deright opened this issue May 17, 2019 · 3 comments
Closed

managesieve vacation: UI should allow display names in from field #6760

c0deright opened this issue May 17, 2019 · 3 comments

Comments

@c0deright
Copy link

Current code prevents users from creating a vacation rule where the From field contains a display-name like

My Name <foo@example.com>

so the out-of-office reply would contain the header

From: My Name <foo@example.com>

Right now you're forced by UI to use

foo@example.com

which results in header

From: foo@example.com

which then results in mails likely getting marked as Junk by the receiving MTA.

It's basically the same issue as outlined in cyrusimap/cyrus-imapd#2189.

It's perfectly legal to use

vacation :days 14 :addresses ["..."] :subject "..." :from "My Name <foo@example.com>"

in a sieve script.

In fact, I just edited the sieve script with vim and did test the out-of-office reply and can confirm that the ooo email now has a header From: My Name <foo@example.com> instead of From: foo@example.com.

@alecpl
Copy link
Member

alecpl commented May 17, 2019

Confirmed with RFC 5230.

@alecpl alecpl added this to the later milestone May 17, 2019
alecpl added a commit to alecpl/roundcubemail that referenced this issue May 20, 2019
@alecpl
Copy link
Member

alecpl commented May 20, 2019

PR created in #6763.

@alecpl
Copy link
Member

alecpl commented Jan 5, 2020

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants