Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add to addressbook on send. #4971

Closed
rcubetrac opened this issue Aug 5, 2006 · 22 comments
Closed

Automatically add to addressbook on send. #4971

rcubetrac opened this issue Aug 5, 2006 · 22 comments

Comments

@rcubetrac
Copy link

Reported by Zelest on 5 Aug 2006 21:24 UTC as Trac ticket #1483935

It would be nice to have an option (could be turned off by default) which allow you to automatically add someone in your addressbook when you send a mail to them. I for one would love this as my antispam system could take advantage of it.

If you consider adding this feature, what about having 3 options? One that disables it (default?), a second one that automatically adds addresses to the addressbook and a third option which simply ask the user "do you want to add foo@bar.tld to your addressbook?".

Migrated-From: http://trac.roundcube.net/ticket/1483935

@rcubetrac
Copy link
Author

Comment by @thomascube on 29 Aug 2006 11:20 UTC

Marked #1324820 as duplicate of this.

@rcubetrac
Copy link
Author

Owner changed by @thomascube on 29 Aug 2006 11:20 UTC

=> none

@rcubetrac
Copy link
Author

Severity changed by @thomascube on 29 Aug 2006 11:20 UTC

normal => minor

@rcubetrac
Copy link
Author

Milestone changed by @thomascube on 29 Aug 2006 11:20 UTC

=> later

@rcubetrac
Copy link
Author

Comment by rosali on 29 Jul 2009 11:42 UTC

It is on my ToDo's for a plugin.

@rcubetrac
Copy link
Author

Comment by sckramer on 19 Mar 2010 15:12 UTC

any work done on this... we have people asking for it-- thanks!!

@rcubetrac
Copy link
Author

Comment by rosali on 20 Mar 2010 06:09 UTC

Test automatic_addressbook plugin (http://myroundcube.googlecode.com).

@rcubetrac
Copy link
Author

Comment by rosali on 23 Apr 2012 16:36 UTC

Plugin automatic_addressbook is now hosted @

http://code.crapouillou.net/projects/roundcube-plugins

@rcubetrac
Copy link
Author

Comment by thonixx on 3 Mar 2013 22:34 UTC

Replying to rosali:

Plugin automatic_addressbook is now hosted @

http://code.crapouillou.net/projects/roundcube-plugins
thanks :)

@rcubetrac
Copy link
Author

Comment by @thomascube on 26 Oct 2014 11:48 UTC

Schedule for next major milestone

@rcubetrac
Copy link
Author

Milestone changed by @thomascube on 26 Oct 2014 11:48 UTC

later => 1.2-beta

@rcubetrac
Copy link
Author

Comment by @alecpl on 9 Sep 2015 10:46 UTC

I reviewed the autocomplete_addressbook plugin and I don't really like it as it is now. Some changes will be needed:

  1. The code should be cleaned to remove redundant backward compat. code.
  2. The engine should be re-implemented with use of a smaller database table. I.e. we store only name, email and user_id, all other columns should be removed.
  3. There's an option to enable/disable the collected addresses source at all. Thunderbird, for example allows to store "collected addresses" in any existing addressbook.
  4. I'm not sure, when collecting addresses, if we should check address existence in all addressbook sources. It may be a heavy operation for multi-source installations like Kolab.
  5. Maybe add an option to select which mail headers to use for addresses, .i.e. one could choose to use only To: but not Cc:.

@rcubetrac
Copy link
Author

Comment by @thomascube on 22 Nov 2015 14:18 UTC

Rescheduling...

@rcubetrac
Copy link
Author

Milestone changed by @thomascube on 22 Nov 2015 14:18 UTC

1.2-beta => 1.3-beta

@bostjan
Copy link
Contributor

bostjan commented Apr 11, 2016

My inconvenience with the automatic_addressbook is the fact that it uses separate table for address collection. Any good reason for that? If address is missing from all current address books, it should add it to Personal address book and optionally assign it to a group called "Autocollected addresses" (if and which group should be configurable).

b.

@alecpl
Copy link
Member

alecpl commented Aug 3, 2016

I must admit that I didn't think about using groups for this purpose. In Kolab you can have many personal addressbooks so using a book sounded reasonable to me. Also other clients use a separate addressbook (e.g. Thunderbird). I kind of liked the idea of using groups, but... we don't have in Addressbook an option to skip selected group (show all contacts except this one group), so when user would want to browse his addressbook he would see all contacts and collected addresses at once which may be not so nice.

@bostjan
Copy link
Contributor

bostjan commented Aug 3, 2016

Yes, on this edge use case I agree that using multiple address books is reasonable :)

Joking aside, my itch has already been scratched, here:
https://plugins.roundcube.net/packages/teon/automatic_addressbook_ng

I must admit that I really do not remember WHY I disliked the multi-addressbook idea originally - it might have something to do with address autocompletion work I was doing at the time (https://plugins.roundcube.net/packages/teon/smart_autocomplete), as that work was done with RoundCube webmail as primary and only mail interface in mind.

@alecpl alecpl modified the milestones: 1.4-beta, 1.3-beta Nov 30, 2016
@alecpl alecpl modified the milestones: 1.4-beta, later Nov 24, 2017
@kodemafia
Copy link

automatic_addressbook is not working if we are hiding the global address book. The saved ids are not comming in compose window in autocompletion.

@labcerouno
Copy link

wow! This is 14 years old...

@alecpl alecpl modified the milestones: later, 1.5-beta Sep 20, 2020
alecpl added a commit that referenced this issue Sep 20, 2020
Added configurable Collected Recipients addressbook source (#4971)
Added configurable Trusted Senders addressbook source (#5046)
Added 'contact_exists' hook
@alecpl
Copy link
Member

alecpl commented Sep 20, 2020

Feature implemented.

@alecpl alecpl closed this as completed Sep 20, 2020
@antonical
Copy link

I have the latest version installed and connot find this option to enable it. Can you advise how to enable this functionality please.

Cheers
Tony

@navossoc
Copy link
Contributor

navossoc commented Jun 9, 2022

I have the latest version installed and connot find this option to enable it. Can you advise how to enable this functionality please.

Cheers Tony

On Roundcube 1.5:
Settings -> Preferences -> Contacts

Look for Collected addresses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants