Add --snapshot-mode argument to the "record" verb #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camm73
requested review from
lihui815 and
jhdcs
and removed request for
a team
jhdcs
approved these changes
Aug 24, 2021
|
I'd pull the whole "expose to Python" portion into here. Make #850 be purely the C++ portion, skip |
camm73
force-pushed
the
cameron/snapshot-python-integration
branch
from
088bb72
to
79b4362
Compare
added 3 commits
September 24, 2021 13:23
Signed-off-by: Cameron Miller <cammlle@amazon.com>
Signed-off-by: Cameron Miller <cammlle@amazon.com>
Signed-off-by: Cameron Miller <cammlle@amazon.com>
emersonknapp
force-pushed
the
cameron/snapshot-python-integration
branch
from
79b4362
to
b50453a
Compare
emersonknapp
approved these changes
Sep 24, 2021
|
87 tasks
YXL76
pushed a commit
to YXL76/rosbag2
that referenced
this pull request
Nov 18, 2022
* Add snapshot mode parameter to record verb Signed-off-by: Cameron Miller <cammlle@amazon.com>
YXL76
pushed a commit
to YXL76/rosbag2
that referenced
this pull request
Nov 18, 2022
* Add snapshot mode parameter to record verb Signed-off-by: Cameron Miller <cammlle@amazon.com>
YXL76
pushed a commit
to YXL76/rosbag2
that referenced
this pull request
Nov 18, 2022
* Add snapshot mode parameter to record verb Signed-off-by: Cameron Miller <cammlle@amazon.com>
YXL76
pushed a commit
to YXL76/rosbag2
that referenced
this pull request
Nov 18, 2022
* Add snapshot mode parameter to record verb Signed-off-by: Cameron Miller <cammlle@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #663
Extends #844
Extends #850
This PR adds the
--snapshot-modeargument to the Python CLIrecordverb. It also updates the original design document to reflect minor changes to the implementation.