Design proposal for snapshot feature #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camm73
requested review from
lihui815 and
Karsten1987
and removed request for
a team
Signed-off-by: Cameron Miller <cammlle@amazon.com>
camm73
force-pushed
the
cameron/snapshot-design-proposal
branch
from
d538c2f
to
daac940
Compare
emersonknapp
approved these changes
Aug 4, 2021
Signed-off-by: Cameron Miller <cammlle@amazon.com>
emersonknapp
approved these changes
Aug 5, 2021
camm73
added a commit
to camm73/rosbag2
that referenced
this pull request
Aug 6, 2021
* Create design proposal for snapshot feature Co-authored-by: Cameron Miller <cammlle@amazon.com> Signed-off-by: Cameron Miller <cammlle@amazon.com>
WJaworskiRobotec
pushed a commit
to RobotecAI/rosbag2
that referenced
this pull request
Sep 12, 2021
* Create design proposal for snapshot feature Co-authored-by: Cameron Miller <cammlle@amazon.com> Signed-off-by: Wojciech Jaworski <wojciech.jaworski@robotec.ai>
Timple
reviewed
Oct 24, 2021
|
|
||
| Starting `rosbag2` in snapshot mode with a specified cache size: | ||
| ``` | ||
| $ ros2 bag record --max-cache-size 100000 --snapshot-mode [topics [topics ...]] |
There was a problem hiding this comment.
Next to --max-cache-size 100000, --max-cache-duration 30 would be nice.
Omitting one would mean no limit.
YXL76
pushed a commit
to YXL76/rosbag2
that referenced
this pull request
Nov 18, 2022
* Create design proposal for snapshot feature Co-authored-by: Cameron Miller <cammlle@amazon.com>
YXL76
pushed a commit
to YXL76/rosbag2
that referenced
this pull request
Nov 18, 2022
* Create design proposal for snapshot feature Co-authored-by: Cameron Miller <cammlle@amazon.com>
YXL76
added a commit
to YXL76/rosbag2
that referenced
this pull request
Nov 18, 2022
* Create design proposal for snapshot feature Co-authored-by: Cameron Miller <cammlle@amazon.com> Co-authored-by: YXL <chenxin.lan.76@gmail.com>
YXL76
pushed a commit
to YXL76/rosbag2
that referenced
this pull request
Nov 18, 2022
* Create design proposal for snapshot feature Co-authored-by: Cameron Miller <cammlle@amazon.com>
YXL76
pushed a commit
to YXL76/rosbag2
that referenced
this pull request
Nov 18, 2022
* Create design proposal for snapshot feature Co-authored-by: Cameron Miller <cammlle@amazon.com>
YXL76
pushed a commit
to YXL76/rosbag2
that referenced
this pull request
Nov 18, 2022
* Create design proposal for snapshot feature Co-authored-by: Cameron Miller <cammlle@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #663 for details on the original feature request.