Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate `nodes_only in opq function #308

Open
jmaspons opened this issue Feb 6, 2023 · 1 comment · Fixed by #312
Open

Deprecate `nodes_only in opq function #308

jmaspons opened this issue Feb 6, 2023 · 1 comment · Fixed by #312
Assignees
@jmaspons

Comments

@jmaspons
Copy link
Collaborator

jmaspons commented Feb 6, 2023

The parameter nodes_only is superseded and equivalent to osm_types="node". It can be deprecated. Proposed phases:

  1. Warn in the documentation for the next release.
  2. Throw a warning in next+1 release
  3. Remove the parameter en next+2 release.

Thoughts, @mpadge ?
@mpadge
Copy link
Member

mpadge commented Feb 7, 2023

Sounds like a great plan. Do you want to PR the doc changes then? Or else feel free to assign me to the issue if you want. Then we really need to get the release out! 🚀

@jmaspons jmaspons assigned mpadge and jmaspons and unassigned mpadge Feb 7, 2023
jmaspons added a commit to jmaspons/osmdata that referenced this issue Feb 8, 2023
@jmaspons
Deprecated nodes_only as per ropensci#308
307352e
@jmaspons jmaspons mentioned this issue Feb 8, 2023
Merged
mpadge added a commit that referenced this issue Feb 8, 2023
@mpadge
Merge pull request #312 from jmaspons/deprecate_nodes_only
2f30538 
Deprecate nodes_only as per #308
@jmaspons jmaspons reopened this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmaspons jmaspons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate nodes_only as per #308 jmaspons/osmdata
2 participants
@jmaspons @mpadge