Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pkgdown issues #112

Closed
jeroen opened this issue Jul 5, 2024 · 46 comments
Closed

New pkgdown issues #112

jeroen opened this issue Jul 5, 2024 · 46 comments

Comments

@jeroen
Copy link
Contributor

jeroen commented Jul 5, 2024

A few test pages:

Also there is an issue with the favicons. In the previous version we used common favicons on docs.ropensci.org e.g.

And so on. However the new page has favicons in the pkgdown site, but those are missing:

Writing to: /tmp/Rtmpror1TN/unrtf
── Sitrep ──────────────────────────────────────────────────────────────────────
✔ URLs ok.
✖ Favicons not ok.
  Package logo is newer than favicons.
  Do you need to rerun `build_favicons()`?
✔ Open graph metadata ok.
✔ Articles metadata ok.
✔ Reference metadata ok.
@maelle
Copy link
Contributor

maelle commented Jul 5, 2024

Regarding the search box disappearance, it's due to a fix in pkgdown https://github.com/r-lib/pkgdown/blob/main/NEWS.md#_pkgdownyaml

You can now choose where the search box is placed with the "search" navbar component. This has been documented for a very long time, but as far as I can tell, never worked (#2320). If you have made your own template with a custom navbar, you will need to remove the

with role="search" to avoid getting two search boxes.

The fix has to happen on the side of the packages as in ropensci/magick#401, unless we want to add some sort of compatibility layer within rotemplate.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle
Copy link
Contributor

maelle commented Jul 17, 2024

mustberuss added a commit to mustberuss/patentsview that referenced this issue Jul 17, 2024
mustberuss added a commit to mustberuss/patentsview that referenced this issue Jul 17, 2024
@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

@maelle

This comment was marked as resolved.

mustberuss added a commit to mustberuss/patentsview that referenced this issue Aug 5, 2024
mustberuss added a commit to mustberuss/patentsview that referenced this issue Aug 5, 2024
@maelle

This comment was marked as resolved.

@maelle
Copy link
Contributor

maelle commented Aug 12, 2024

ropensci/iheatmapr#109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants