Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] allow admin to choose the share URL #426

Open
tionis opened this issue Apr 8, 2022 · 6 comments
Open

[Feature Request] allow admin to choose the share URL #426

tionis opened this issue Apr 8, 2022 · 6 comments
Milestone

Comments

@tionis
Copy link

tionis commented Apr 8, 2022

It would be awesome if an admin could choose the share URL when uploading, so that they could for example recreate shares or use vanity URLs (which may of course be easier to guess)

@tionis
Copy link
Author

tionis commented Apr 8, 2022

This would be especially useful in combination with #412

@camathieu
Copy link
Member

#412 has been implemented already :)

To confirm, by "choose URL" you mean an extra upload parameter where the admin could choose the download path of an upload (on the same download domain) ?

Like plik --server https://plik.root.gg --download-path /myfile myfile
would lead the the file being exposed on https://plik.root.gg/myfile

Honestly I like the idea a lot. And it can be a very fun one to implement. We'll have to blacklist a few keywords as we had the very bad idea to not use a /api prefix for API when we created the project 8 years ago but that's not a big deal.

@camathieu camathieu added this to the 1.3.6 milestone Apr 9, 2022
@tionis
Copy link
Author

tionis commented Apr 9, 2022

Yeah exactly something like that

@tionis
Copy link
Author

tionis commented Apr 9, 2022

I actually got a few more feature ideas but don't want to spam the repo, should I still post them as issues or do you have a forum/room for discussion?

@camathieu
Copy link
Member

camathieu commented Apr 10, 2022 via email

@camathieu
Copy link
Member

This change as well as a few other requires that file names are unique in an upload so that it's possible to not rely on the uploadID/fileID everywhere. Changing milestone to 1.3.7.

@camathieu camathieu modified the milestones: 1.3.6, 1.3.7 May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants