mons: restore-quorum should proceed with probing #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, mon restore-quorum fails if mon status is not in leader or peon but it should also include probing state as when majority of the mons down mons goes to probing state until it finds the other mons. Signed-off-by: subhamkrai <srai@redhat.com>
upload-artifact version v2 is depricated, we need to update to latest version Signed-off-by: subhamkrai <srai@redhat.com>
travisn
approved these changes
Sep 11, 2024
parth-gr
reviewed
Sep 11, 2024
| @@ -327,7 +327,7 @@ func validateMonIsUp(ctx context.Context, clientsets *k8sutil.Clientsets, cluste | |||
|
|
|||
| logging.Info("mon %q state is %q", monID, monStatusOut.State) | |||
|
|
|||
| if monStatusOut.State == "leader" || monStatusOut.State == "peon" { | |||
| if monStatusOut.State == "leader" || monStatusOut.State == "peon" || monStatusOut.State == "probing" { | |||
There was a problem hiding this comment.
@subhamkrai try to change this error message in future PR
return fmt.Errorf("mon %q in %q state but must be in leader/peon/probing state", monID, monStatusOut.State)
travisn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, mon restore-quorum fails if mon status is not in leader or peon but it should also include probing state as when majority of the mons down mons goes to probing state until it finds the other mons.
Issue resolved by this Pull Request:
Resolves #323
Checklist: