core: Add status.phase=Running filter to WaitForPodToRun #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent pods in the 'Completed' phase to show up in the list pulled by WaitForPodToRun (which resulted in an indefinitely hang), add a filter to only return pods in the 'Running' phase. Signed-off-by: Simon Brakhane <simon@brakhane.net>
Luminger
force-pushed
the
add-WaitForPodToRun-status-filter
branch
from
b50aa53
to
6ed8906
Compare
Luminger
changed the title
|
The test failure seems to be a transient error during deletion of the test cluster, can we redo the test run? |
restarted, now |
subhamkrai
approved these changes
Jun 28, 2024
|
Thanks for the PR @Luminger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent pods in the
Completedphase to show up in the list pulled byWaitForPodToRun(which resulted in an indefinitely hang), add a filter to only return pods in theRunningphase.Issue resolved by this Pull Request:
Resolves #304
Checklist: