core: adding 'radosgw-admin' command support #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhamkrai
force-pushed
the
add-radosgw-admin
branch
2 times, most recently
from
23c393a
to
61aef7d
Compare
travisn
requested changes
Jun 3, 2024
cmd/commands/radosgw.go
Outdated
| // RadosgwCmd represents the radosgw command | ||
| var RadosgwCmd = &cobra.Command{ | ||
| Use: "radosgw-admin", | ||
| Short: "call a 'radosgw-admin' CLI command with arbitrary args", |
There was a problem hiding this comment.
Suggested change
| Short: "call a 'radosgw-admin' CLI command with arbitrary args", | |
| Short: "call a 'radosgw-admin' CLI command", |
docs/radosgw-admin.md
Outdated
| ## Examples | ||
|
|
||
| ```bash | ||
| kubectl rook-ceph radosgw-admin user create --display-name="johnny rotten" --uid=johnny |
There was a problem hiding this comment.
rotten? This suggestion might be boring though :)
Suggested change
| kubectl rook-ceph radosgw-admin user create --display-name="johnny rotten" --uid=johnny | |
| kubectl rook-ceph radosgw-admin user create --display-name="my user" --uid=myuser |
Closed
subhamkrai
force-pushed
the
add-radosgw-admin
branch
2 times, most recently
from
f45cc80
to
0d26a17
Compare
travisn
requested changes
Jun 4, 2024
subhamkrai
force-pushed
the
add-radosgw-admin
branch
from
0d26a17
to
872f1c7
Compare
travisn
approved these changes
Jun 6, 2024
adding support for 'radosgw-admin' command in the cli tool and also adding docs and ci. Signed-off-by: subhamkrai <srai@redhat.com>
subhamkrai
force-pushed
the
add-radosgw-admin
branch
from
872f1c7
to
e89ebf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding support for 'radosgw-admin' command in the cli tool and also adding docs and ci.
Issue resolved by this Pull Request:
Resolves #253
Checklist: