clean: use cobra built-in feature for pre-validation #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhamkrai
force-pushed
the
clean-repetitive-code
branch
4 times, most recently
from
e945f59
to
ec47c5e
Compare
Let's use cobra `PreRun`,`PreRunE`, `PersistentPreRun` and `PersistentPreRun` feature to do pre-validation checks. Also, refactor the code. Signed-off-by: subhamkrai <srai@redhat.com>
subhamkrai
force-pushed
the
clean-repetitive-code
branch
from
ec47c5e
to
ab16b18
Compare
travisn
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use cobra
PreRun,PreRunE,PersistentPreRunandPersistentPreRunfeature to do pre-validation checks. Also, refactor the code.Checklist:
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist: