namespace: namespace flags are not working #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: subhamkrai <srai@redhat.com>
cluster namespace and operator namespace needs better handling. It was throwing an error and was exited when namespace args are passed. Now, the default cluster ns is rook-ceph, and for operator it is empty but we check later in the code that if CephClusterNamespace != "" && OperatorNamespace == "" then assign the cluster ns to operator ns. Signed-off-by: subhamkrai <srai@redhat.com>
subhamkrai
force-pushed
the
fix-ns-arg-issue
branch
from
23c1e22
to
f250e2e
Compare
travisn
approved these changes
Jun 22, 2023
|
Maybe early next week we can plan on releasing v0.5.1, in case any other fixes are needed as well |
yes, since the issue with then namespace is really annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namespace: namespace flags are not working
cluster namespace and operator namespace needs
better handling. It was throwing an error and was exited
when namespace args are passed.
Now, the default cluster ns is rook-ceph, and for
operator it is empty but we check later in the code
that if CephClusterNamespace != "" && OperatorNamespace == ""
then assign the cluster ns to operator ns.
ci: add CI to test the plugin in different namespace
Signed-off-by: subhamkrai srai@redhat.com
fixes: #129