Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Instructions for building on Windows 10. #216

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Conversation

Tembocs
Copy link
Contributor

@Tembocs Tembocs commented Mar 27, 2020

On Windows the cd rome; ./scripts/build-release dist does not work. The following works on Windows; cd rome && node scripts/build-release dist. This requires PowerShell 7 just for the && to work.

@facebook-github-bot
Copy link

Hi @Tembocs!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sebmck sebmck merged commit 6420cc5 into rome:master Mar 28, 2020
@sebmck
Copy link
Contributor

sebmck commented Mar 28, 2020

We have a Windows section in CONTRIBUTING. Happy to merge this but that whole page in the docs will be going away once we have a published release #18. Thanks for the RP!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants