This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Add support for diagnostics suppressions #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for #20. Right now suppressions will take the form of:
This same suppression logic is used for all diagnostics produced by Rome. This supports multiple categories for suppressions.
We can bikeshed on the actual comment prefix later, whether it's
rome-ignore,rome-suppress,@rome-ignore, or whatever.We may also want to enforce a suppression description.
One side effect of the suppressions is that it also works for suppressing syntax errors... Not sure if we want to keep that, but it's cool.