feat(rome_js_analyze): new lint rule noExcessiveComplexity (#4657)

rome · Jul 6, 2023 · 8f46efb · 8f46efb
1 parent 10fb3d4
commit 8f46efb
Show file tree

Hide file tree

Showing 54 changed files with 1,817 additions and 98 deletions.
diff --git a/crates/rome_analyze/CONTRIBUTING.md b/crates/rome_analyze/CONTRIBUTING.md
@@ -463,7 +463,7 @@ impl Visitor for MissingYieldVisitor {
                 // entry of the stack and the `has_yield` flag is `false`, emit a query match
                 if let Some(exit_node) = AnyFunctionLike::cast_ref(node) {
                     if let Some((enter_node, has_yield)) = self.stack.pop() {
-                        assert_eq!(enter_node, exit_node);
+                        debug_assert_eq!(enter_node, exit_node);
                         if !has_yield {
                             ctx.match_query(MissingYield(enter_node));
                         }

diff --git a/crates/rome_diagnostics_categories/src/categories.rs b/crates/rome_diagnostics_categories/src/categories.rs
@@ -104,6 +104,7 @@ define_categories! {
     "lint/nursery/useArrowFunction": "https://docs.rome.tools/lint/rules/useArrowFunction",
     "lint/nursery/noVoid": "https://docs.rome.tools/lint/rules/noVoid",
     "lint/nursery/noNonoctalDecimalEscape": "https://docs.rome.tools/lint/rules/noNonoctalDecimalEscape",
+    "lint/nursery/noExcessiveComplexity": "https://docs.rome.tools/lint/rules/noExcessiveComplexity",
     // Insert new nursery rule here
 
 

diff --git a/crates/rome_js_analyze/src/analyzers/correctness/use_yield.rs b/crates/rome_js_analyze/src/analyzers/correctness/use_yield.rs
@@ -4,11 +4,8 @@ use rome_analyze::{
     Visitor, VisitorContext,
 };
 use rome_console::markup;
-use rome_js_syntax::{
-    AnyJsFunction, JsLanguage, JsMethodClassMember, JsMethodObjectMember, JsStatementList,
-    JsYieldExpression, TextRange, WalkEvent,
-};
-use rome_rowan::{declare_node_union, AstNode, AstNodeList, Language, SyntaxNode};
+use rome_js_syntax::{AnyFunctionLike, JsLanguage, JsYieldExpression, TextRange, WalkEvent};
+use rome_rowan::{AstNode, AstNodeList, Language, SyntaxNode};
 
 declare_rule! {
     /// Require generator functions to contain `yield`.
@@ -48,40 +45,6 @@ declare_rule! {
     }
 }
 
-declare_node_union! {
-    pub(crate) AnyFunctionLike = AnyJsFunction | JsMethodObjectMember | JsMethodClassMember
-}
-
-impl AnyFunctionLike {
-    fn is_generator(&self) -> bool {
-        match self {
-            AnyFunctionLike::AnyJsFunction(any_js_function) => any_js_function.is_generator(),
-            AnyFunctionLike::JsMethodClassMember(method_class_member) => {
-                method_class_member.star_token().is_some()
-            }
-            AnyFunctionLike::JsMethodObjectMember(method_obj_member) => {
-                method_obj_member.star_token().is_some()
-            }
-        }
-    }
-
-    fn statements(&self) -> Option<JsStatementList> {
-        Some(match self {
-            AnyFunctionLike::AnyJsFunction(any_js_function) => any_js_function
-                .body()
-                .ok()?
-                .as_js_function_body()?
-                .statements(),
-            AnyFunctionLike::JsMethodClassMember(method_class_member) => {
-                method_class_member.body().ok()?.statements()
-            }
-            AnyFunctionLike::JsMethodObjectMember(method_obj_member) => {
-                method_obj_member.body().ok()?.statements()
-            }
-        })
-    }
-}
-
 #[derive(Default)]
 struct MissingYieldVisitor {
     /// Vector to hold a function node and a boolean indicating whether the function

diff --git a/crates/rome_js_analyze/src/analyzers/nursery.rs b/crates/rome_js_analyze/src/analyzers/nursery.rs