Add unit tests #30
Open
Add unit tests #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging is blocked until:
|
stribor14
force-pushed
the
unit-tests
branch
6 times, most recently
from
dcb2e77
to
86bfcb9
Compare
stribor14
force-pushed
the
unit-tests
branch
from
86bfcb9
to
55f86d5
Compare
|
I pushed few commits to fix some workflow changes, and to acquire a knowledge of how it works |
stribor14
requested changes
Sep 20, 2024
| EXPECT_EQ(end_points_expected, point_curve) << "Curve end points differ from expected"; | ||
| } | ||
|
|
||
| TEST_F(BezierTest, CurvePolylineTest) |
There was a problem hiding this comment.
Instead of just blindly checking point-for-point (which can change in smallest details from commit to commit), it would be better to check with some algorithmic knowledge.
Here is the example for this function:
- create 2 polylines with different parameters for flatness, and compare max deviation from default polyline (computed as root-mean-square-distance)
|
|
||
| TEST_F(BezierTest, CurveEndPointsTest) | ||
| { | ||
| std::pair<Point, Point> end_points_expected{getCurvePointsAsPointVector().at(0), |
|
|
||
| TEST_F(BezierTest, CurveValueAtTest) | ||
| { | ||
| std::vector<double> t_vals{0., 0.25, 0.5, 0.75, 1}; |
There was a problem hiding this comment.
constexpr std::array t_vals{0., 0.25, 0.5, 0.75, 1};
There was a problem hiding this comment.
and for all other instances also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.