Fixes bug that caused some payload fields to become invalid #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that the serializer was being run on the final payload object which had references in the request dict to local variables in the trace frames. This caused request.params = <CircularReference ...> which is invalid according to the Rollbar API schema. This change serializes the payload in sections so that each section cannot reference the other while checking for circular references. @brianr
coryvirok
added a commit
that referenced
this pull request
Oct 9, 2015
…parately Fixes bug that caused some payload fields to become invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the serializer was being run on the final payload
object which had references in the request dict to local variables in
the trace frames. This caused request.params = <CircularReference ...>
which is invalid according to the Rollbar API schema.
This change serializes the payload in sections so that each section
cannot reference the other while checking for circular references.
@brianr