Don't try to build request data if outside request context #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reasonable test we could write for this? |
|
Seems like trying to add in a test for non-request context Flask errors is pretty specific, given that we don't have any existing framework specific-tests in the suite. Maybe someday... |
brianr
added a commit
that referenced
this pull request
Sep 3, 2015
Don't try to build request data if outside request context
| actual_request = request._get_current_object() | ||
| try: | ||
| actual_request = request._get_current_object() | ||
| except RuntimeError: |
There was a problem hiding this comment.
A comment here would be helpful for maintenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the rollbar log handler in Flask apps, if you try to report errors outside the request context (e.g. in background workers), you'll see RuntimeErrors in your local logs as rollbar tries to populate the request data for the error report.
This commit cleans up the logs by suppressing that exception.