Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AppEngine support to pyrollbar module (fixes #42) #53

Merged
merged 1 commit into from
Mar 3, 2015
Merged

Adds AppEngine support to pyrollbar module (fixes #42) #53

merged 1 commit into from
Mar 3, 2015

Conversation

fjorgemota
Copy link
Contributor

Please, check that change with the maximum attention. I feel much like the code is a bit duplicated (just some lines have been modified), but that's all for using pyrollbar with AppEngine. (checked as working in dev_appserver.py of AppEngine's SDK)

And it fixes issue #42, too. =)

Thanks. =)

@fjorgemota fjorgemota changed the title Adds AppEngine support to pyrollbar module (fixes #42) Adds AppEngine support to pyrollbar module (fixes GH-42) Feb 27, 2015
@fjorgemota fjorgemota changed the title Adds AppEngine support to pyrollbar module (fixes GH-42) Adds AppEngine support to pyrollbar module (fixes #42) Feb 27, 2015
@brianr
Copy link
Member

brianr commented Feb 27, 2015

Thanks for the PR, @fjorgemota ! We'll get this reviewed and merged shortly.

@fjorgemota
Copy link
Contributor Author

Awesome, thanks @brianr. I'll await a review. =)

@coryvirok
Copy link
Contributor

I've verified that this works in my dev environment although I had to go through some crazy hoops to get it working with App Engine, (http://stackoverflow.com/questions/16192916/importerror-no-module-named-ssl-with-dev-appserver-py-from-google-app-engine/16937668#16937668)

Thanks for the PR!

coryvirok added a commit that referenced this pull request Mar 3, 2015
Adds AppEngine support to pyrollbar module (fixes #42)
@coryvirok coryvirok merged commit 95a592a into rollbar:master Mar 3, 2015
@fjorgemota
Copy link
Contributor Author

Awesome, thanks, @coryvirok! :D

@ekampf
Copy link

ekampf commented Jun 18, 2015

@fjorgemota @coryvirok if you're on AppEngine, you probably are not using (and don't have) the 'requests' library... which means you'll fail on init.py "import requests" no?

@fjorgemota
Copy link
Contributor Author

@ekampf Hey, i'm using this module in production at matrufsc2.appspot.com (the repository is here: http://github.com/matrufsc2/matrufsc2) and it seems to work correctly, even with that line on init.py file.

Are you suffering from a related caused by that line?

Thanks.

@ekampf
Copy link

ekampf commented Jun 18, 2015

@fjorgemota yes. my code throws on that line (and if I comment it out on it crashes on line #1177:

if isinstance(resp, requests.Response):

in _parse_response

How come your code successfully imports requests? its not part of the default app engine stack...

@fjorgemota
Copy link
Contributor Author

@ekampf As I remember, seems like you can INSTALL requests normally (in my case, I installed it using gaenv, which allow the use of any library in Pypi easily in AppEngine), but you CANNOT use requests to make requests.

Because this my project can import requests, but uses the GAE support added in this pull request to send exception from AppEngine's Python environment to Rollbar using URLFetch. =)

@ekampf
Copy link

ekampf commented Jul 27, 2015

@fjorgemota got it!
Still would be nice if you wouldn't have to install requests at all (as its not being used)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants