Allow to send requests with Tornado`s AsyncHTTPClient #34
Conversation
|
Yay, I've broken support for Python < 3.3 :( |
|
Thanks for the PR. We will need to maintain support for older versions of python before we can merge this though. Let me know if you'd like some suggestions... |
|
Fixed. Can you please check it again? |
| @@ -275,6 +287,11 @@ def send_payload(payload): | |||
| elif handler == 'agent': | |||
| payload = ErrorIgnoringJSONEncoder().encode(payload) | |||
| agent_log.error(payload) | |||
| elif handler == 'tornado': | |||
| if tornado_coroutine is None: | |||
There was a problem hiding this comment.
This line looks unnecessary since tornado_coroutine will always be defined (line 83)... right?
There was a problem hiding this comment.
Yep, confused TornadoAsyncHTTPClient with tornado_coroutine
|
See that one comment on the latest diff. The rest looks great. |
|
Fixed again :) Also i've squashed all into 1 commit. |
|
Looks great, thanks! Will merge once the travis build runs and passes. |
|
Wow, thank you. Looking forward to see this commit in next release :) |
Allow to send requests with Tornado's AsyncHTTPClient
|
Pushed to pypi in 0.9.1. Thanks again! |
No description provided.