Fix Django deprecation warning #165
Conversation
|
Thanks for the PR! I'll take a look. |
rollbar/contrib/django/middleware.py
Outdated
| from django.conf import settings | ||
| from django.http import Http404 | ||
|
|
||
| if django.VERSION >= (1, 10): |
There was a problem hiding this comment.
Hmm, I'm not sure if this is the right way to do this particular comparison. django.VERSION usually has text in it. For example, (1, 11, 1, u'final', 0).
I know this is probably not necessary and really corner case-y, but I think it might be better to do an import check similar to how we handle MiddlewareMixin below.
There was a problem hiding this comment.
I'm happy to change it but checking the version is a pretty common pattern:
There was a problem hiding this comment.
Thanks for the link. That's definitely something to consider since a method could change to a property and vice-versa. I'm going to file an internal ticket to discuss with the team.
|
Updated to use try/except. |
No description provided.