Lint plugin src #846
Merged
Lint plugin src #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boatbomber
added
scope: plugin
Dekkonot
approved these changes
Feb 1, 2024
|
Next step: static types, right? :P |
|
We'll drag Rojo into the modern era kicking and screaming if we have to |
kennethloeffler
pushed a commit
to kennethloeffler/rojo
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been on my pet peeves list for a while.
Enforces selene via CI. This PR comes with a whole bunch of tiny fixes for things that make my editor yell at me whenever I work on Rojo.
Also, after fixing lints on
createSignalI noticed that it's totally unused. It's 4 years old with the last commit being "for future work" which evidently never came. So, I removed it.