Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin template #738

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Add plugin template #738

merged 6 commits into from
Jul 24, 2023

Conversation

nezuo
Copy link
Contributor

@nezuo nezuo commented Jul 14, 2023

Adds a new plugin template to the init command: rojo init --kind plugin.

The model template can be used for a plugin but it has a few disadvantages:

  • The default script is a ModuleScript instead of a Script
  • The default script's code is irrelevant to a plugin:
    return {
    hello = function()
    print("Hello world, from {project_name}!")
    end,
    }
  • It does not show the new plugin build flag in the README (Add plugin build flag #735)
  • The .gitignore only ignores place lock files but it should ignore the plugin model file

In the README, I suggest using .rbxm instead of .rbxmx unlike the old templates. Does anyone disagree with this change? Should we update the old templates to suggest this as well?

@boatbomber
Copy link
Member

Yeah, .rbxm is stable now and the more efficient option. I haven't used .rbxmx in a while and we probably shouldn't still be recommending it as the default option.

src/cli/init.rs Outdated Show resolved Hide resolved
@Dekkonot Dekkonot merged commit f6fc559 into rojo-rbx:master Jul 24, 2023
4 checks passed
@nezuo nezuo deleted the new-plugin-template branch July 24, 2023 04:30
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
Adds a new plugin template to the `init` command: `rojo init --kind
plugin`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants