Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show failed to apply in visualizer #717

Merged
merged 9 commits into from
Jul 9, 2023
Merged

Show failed to apply in visualizer #717

merged 9 commits into from
Jul 9, 2023

Conversation

boatbomber
Copy link
Member

Closes #712.

Objects with failed changes will highlight, and the specific failed changes in their list will highlight as well.

image
image

@boatbomber boatbomber added type: enhancement Feature or improvement that should potentially happen scope: plugin Relevant to the Roblox Studio plugin size: small impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. status: needs review This work is mostly done, but just needs work to integrate and merge it. labels Jul 8, 2023
@boatbomber boatbomber requested a review from Dekkonot July 8, 2023 22:02
@boatbomber boatbomber enabled auto-merge (squash) July 8, 2023 22:45
Dekkonot
Dekkonot requested changes Jul 9, 2023
View reviewed changes
Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a minor qualm with the changelog entry!

CHANGELOG.md Outdated Show resolved Hide resolved
plugin/src/App/Components/PatchVisualizer/init.lua Show resolved Hide resolved
@boatbomber boatbomber requested a review from Dekkonot July 9, 2023 02:15
@boatbomber boatbomber merged commit 0a932ff into rojo-rbx:master Jul 9, 2023
4 checks passed
@boatbomber boatbomber deleted the show-failed-to-apply-in-visualizer branch July 9, 2023 02:31
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
@boatbomber
Show failed to apply in visualizer (rojo-rbx#717)
506c34c 
Objects with failed changes will highlight, and the specific failed
changes in their list will highlight as well.
@chenrui333 chenrui333 mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dekkonot Dekkonot Dekkonot approved these changes

Assignees
No one assigned
Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin size: small status: needs review This work is mostly done, but just needs work to integrate and merge it. type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes that fail to apply should be indicated in the patch visualizer somehow
2 participants
@boatbomber @Dekkonot