Support explicitly specifying http or https protocol in plugin #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPGhatguy
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Thanks for filing this PR!
It's important to note that because Rojo has no authentication support in the protocol, running it over the internet is discouraged. Having no authentication also means that TLS doesn't help all that much — you don't need to have a Man in the Middle, an attacker can just send their own requests to the same place!
That said, I'm approving this PR because it's small, tidy, and readable. If we want to support more interesting input, like paths in the URL, we should invest in making a URL parsing package at some point.
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
…rbx#642) * Support explicitly specifying http or https protocol in plugin * Fix incorrect format string Port is not a number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you put in the URL
https://example.com, it would try to send a request tohttp://https://example.cominstead, which would cause an "InvalidUrl" error. This fixes the error by only implicitly addinghttp://if a protocol is not otherwise specified.This change is necessary for a project I'm working on that serves a Rojo project over https (via an SSL termination proxy) in order to prevent man in the middle attacks.