Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for TOML files #633

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Add support for TOML files #633

merged 4 commits into from
Jul 14, 2023

Conversation

Corecii
Copy link
Member

@Corecii Corecii commented Sep 6, 2022

TOML maps well to Lua, is easier to read and write than JSON, and is commonly used by Roblox tools.

Use cases:

  • Put game, plugin, or library config in a toml file
  • Sync in toml files generated by tools
  • Sync in config files for tools so that the game can double-check that the config file has been followed. (e.g. check that packages match versions specified in wally.toml)

@Corecii Corecii mentioned this pull request Sep 6, 2022
Closed
@boatbomber boatbomber added type: enhancement Feature or improvement that should potentially happen scope: cli Relevant to the Rojo CLI size: medium status: needs review This work is mostly done, but just needs work to integrate and merge it. labels Jan 5, 2023
Dekkonot
Dekkonot approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay on responding to this. I've gone ahead and resolved a couple conflicts and updated the changelog for you. This is a good addition, and requested a few times by the broader community. Thanks!

@Dekkonot Dekkonot enabled auto-merge (squash) July 14, 2023 20:30
@Dekkonot Dekkonot merged commit 6e320b1 into rojo-rbx:master Jul 14, 2023
4 checks passed
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
@Corecii
Add support for TOML files (rojo-rbx#633)
9ff2451 
TOML maps well to Lua, is easier to read and write than JSON, and is
commonly used by Roblox tools.

Use cases:
* Put game, plugin, or library config in a toml file
* Sync in toml files generated by tools
* Sync in config files for tools so that the game can double-check that
the config file has been followed. (e.g. check that packages match
versions specified in wally.toml)
@chenrui333 chenrui333 mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dekkonot Dekkonot Dekkonot approved these changes

Assignees
No one assigned
Labels
scope: cli Relevant to the Rojo CLI size: medium status: needs review This work is mostly done, but just needs work to integrate and merge it. type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Corecii @Dekkonot @boatbomber