Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Http Properties upon HttpEnabled prompt #58

Merged
merged 1 commit into from
Apr 8, 2018

Conversation

Validark
Copy link
Contributor

@Validark Validark commented Apr 7, 2018

No description provided.

@LPGhatguy
Copy link
Contributor

Neat, that's a cool way to point people to a solution.

The one issue I see is that the recommended way to change HttpEnabled is now under game settings instead of the (now hidden by default) HttpService. It's possible that HttpEnabled will start being hidden on HttpService in Studio someday soon.

@Validark
Copy link
Contributor Author

Validark commented Apr 7, 2018

I disagree. Here is the description of the Set function:

Set's the client's selected objects to all of those in the table. You can select objects you wouldn't normally be able to like DataModel, SocialService, and other non-browsable Instances.

@Quenty
Copy link
Contributor

Quenty commented Apr 7, 2018

This issue here isn't that the SelectionService:Set() would stop letting you select the service. It's that Roblox can control what properties show up in the properties window. So even if you select the non-browsable instance HttpService there's no guarantee that HttpEnabled is a property you can see.

That being said, I wish there was a more elegant solution.

@Validark
Copy link
Contributor Author

Validark commented Apr 7, 2018

Well, we all use this, so we can easily patch it should Roblox ever change it, but I HIGHLY doubt it will be changed for many, many years. What reason would they have for going back and removing this specific use case? Even if HttpEnabled eventually goes away, this code won't break anything. Worst case scenario is it opens an empty property box and you still have to go to Game Settings.

@LPGhatguy
Copy link
Contributor

Fair point, we can always remove this feature if HttpEnabled isn't visible anymore.

@LPGhatguy LPGhatguy merged commit 31e5c55 into rojo-rbx:master Apr 8, 2018
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants