Infer class name #210
Merged
Infer class name #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kampfkarren
requested changes
Jul 3, 2019
|
I added a snapshot test, but I'm not sure I got everything that is going on in the expected-snapshot file so I really need someone to double check this carefully. The test passes but I just want to make sure it actually test something! |
|
Yeah that test looks fine to me, if there's no |
LPGhatguy
reviewed
Jul 3, 2019
LPGhatguy
reviewed
Jul 4, 2019
jeparlefrancais
force-pushed
the
infer-class-name
branch
from
5806768
to
327e2c8
Compare
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
* infer service names * Update project code and add support for StarterPlayer * Store parent_class in InstigatingSource * Update snapshots Co-authored-by: Lucien Greathouse <me@lpghatguy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179
This will remove the necessity to write the
$classNamefield for services.