Support for .meta.json files other than init #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPGhatguy
approved these changes
Jun 13, 2019
There was a problem hiding this comment.
Looks good to merge and work with in master!
I'll probably restrict what kinds of things can be in .meta.json further by denying unknown properties and making it an error to define properties for rbxmx, rbxm, and model.json files probably.
I'd also like to issue a warning if a single .meta.json file affects zero files, or more than one file, since both cases are probably errors.
This stuff might require some sizable refactoring of this code. 😅
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
* Support for .meta.json files other than init * Localize .meta.json application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truly closes #123.
Thing.server.luawould have a.meta.jsonofThing.meta.json, as said by LPG on Discord.