Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoints stop responding when plugin is connected #133

Closed
LPGhatguy opened this issue Mar 12, 2019 · 0 comments
Closed

Endpoints stop responding when plugin is connected #133

LPGhatguy opened this issue Mar 12, 2019 · 0 comments
Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. regression This bug wasn't a bug in a previous version of Rojo scope: cli Relevant to the Rojo CLI type: bug Something happens that shouldn't happen

Comments

@LPGhatguy
Copy link
Contributor

The upgrade from Rouille to Hyper is good, but Rojo's internal message queue is still using a synchronous channel for responding to a client's long-polling request.

With Rouille, this worked fine, because it uses a large thread pool. With Hyper, this is problematic because it ties up a thread that's expected to return quickly with a Future result.
@LPGhatguy LPGhatguy added type: bug Something happens that shouldn't happen scope: cli Relevant to the Rojo CLI regression This bug wasn't a bug in a previous version of Rojo impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. labels Mar 12, 2019
Dekkonot pushed a commit to UpliftGames/rojo that referenced this issue Jan 11, 2024
@LPGhatguy
Port to futures channel instead of std one.
0fab779 
Fixes rojo-rbx#133.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. regression This bug wasn't a bug in a previous version of Rojo scope: cli Relevant to the Rojo CLI type: bug Something happens that shouldn't happen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LPGhatguy