Int64 and Float64 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A proc macro is probably too much, but I'm definitely interested in expanding the use of traits and regular macros! I've been trying to be pretty cautious since I don't want to introduce fragile abstractions that we'll have to knock down as our understanding of the formats progress! |
|
Looks good! I might go through and update the macro to use something like paste instead of a module, or maybe I'll refactor all of the types to be contained in modules and stop importing them. |
|
I wasn't entirely sure how to make the macro, just that it needed one, that's why the syntax for it is so weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side note, there's a LOT of repetitive code in this codebase. A proc macro would do this wonders.