Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs #130

Merged
merged 53 commits into from
Oct 31, 2020
Merged

docs #130

merged 53 commits into from
Oct 31, 2020

Conversation

JoaoPedroAS51
Copy link
Collaborator

@JoaoPedroAS51 JoaoPedroAS51 commented Oct 22, 2020

Add new docs using Nuxt Content.

See preview in: https://joaopedroas51.github.io/vue-api-query

@JoaoPedroAS51 JoaoPedroAS51 marked this pull request as ready for review October 27, 2020 03:56
Copy link
Collaborator

@Peter-Krebs Peter-Krebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some comments, please reply when you have time.
In general I welcome the changes - but I would like you to clarify some nitpicks of mine (see comments).

Thank you.

README.md Outdated Show resolved Hide resolved
docs/content/en/api/crud-operations.md Show resolved Hide resolved
docs/content/en/api/crud-operations.md Show resolved Hide resolved
docs/content/en/configuration.md Show resolved Hide resolved
docs/content/en/index.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tests/utils.test.js Outdated Show resolved Hide resolved
@JoaoPedroAS51
Copy link
Collaborator Author

JoaoPedroAS51 commented Oct 28, 2020

@Peter-Krebs I see that your concerns are about the tags I used and navigation. So I guess you haven't seen the preview link. Please, check it: https://joaopedroas51.github.io/vue-api-query

I'll mark the conversations about tags and navigation as resolved.

@JoaoPedroAS51
Copy link
Collaborator Author

JoaoPedroAS51 commented Oct 28, 2020

@Peter-Krebs This PR add a documentation website using Nuxt Content.
You can read more about it at: https://content.nuxtjs.org/

@JoaoPedroAS51
Copy link
Collaborator Author

JoaoPedroAS51 commented Oct 28, 2020

@Peter-Krebs If you're curious about how to publish the website:
I added a Github Action to automatically publish the documentation when the code is merged to master branch. It will build the dist files and push them to gh-pages branch, which is used by Github Pages.

@Peter-Krebs
Copy link
Collaborator

Peter-Krebs commented Oct 29, 2020

So I guess you haven't seen the preview link. Please, check it: https://joaopedroas51.github.io/vue-api-query

Ok that flew past me, sorry. I can see why you need the HTML tags then, I apparently never worked with a package using github.io.

This README file already have HTML tags at the top for the badges and the image.

Yes that's how marketing ruins the pure MarkDown syntax. It's not a criticism against you, I just like to reduce the HTML to a minimum where possible.

I just added "read documentation" based on nuxt auth readme. But I agree that it's kind of invisible here.

The link on the nuxt auth page is pretty missable as well I find. It's not a huge problem, but strictly speaking we shouldn't have important things above the first headline.

@JoaoPedroAS51
Copy link
Collaborator Author

@Peter-Krebs I added a section "links", which includes the documentation and release notes. What do you think? 😃

@JoaoPedroAS51
Copy link
Collaborator Author

JoaoPedroAS51 commented Oct 29, 2020

@Peter-Krebs

Yes that's how marketing ruins the pure MarkDown syntax.

Yeah, I agree!

The link on the nuxt auth page is pretty missable as well I find. It's not a huge problem, but strictly speaking we shouldn't have important things above the first headline.

Looking at it again now and I agree with you. I'll update the README of auth module too.

Copy link
Collaborator

@Peter-Krebs Peter-Krebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, looking good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants