YCMEPHelper: Fix enabling YCM_EP_DEVEL_MODE_<project> with Ninja and bump version to 0.16.6
#456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
changed the title
YCM_EP_DEVEL_MODE_<project> with NinjaYCM_EP_DEVEL_MODE_<project> with Ninja
traversaro
changed the title
YCM_EP_DEVEL_MODE_<project> with Ninja YCM_EP_DEVEL_MODE_<project> with Ninja and bump version to 0.16.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix robotology/robotology-superbuild#83 .
Apparently, YCM was designed with explicit support for printing colored Make output, even for custom YCMEPHelper commands (that were enabled for project only if
YCM_EP_DEVEL_MODE_<project>was ON), using the undocumentedcmake -E cmake_echo_colorfunctionality.However, the
cmake_echo_coloroption (and in particular the--switch=$(COLOR)argument) was not working correctly on Ninja. In theory we could investigate how to correctly escape--switch=$(COLOR)to work on Ninja, but in practice ninja historically did not supported colored output by default (see ninja-build/ninja#174), so I think it is just safer to do a normalechowhen not usingUnix Makefilesgenerator.