Improved Custom positions support for yarpmotorgui #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francesco-romano
added
Component: GUI - yarpmotorgui
PR Type: Feat/Enh
francesco-romano
force-pushed
the
motorgui
branch
from
dfd945a
to
27555f5
Compare
|
It seems a great improvement in the usability of the feature. |
|
Wait a second before merging. |
|
Done. Shortcuts added |
|
@randaz81 do you think we can merge this PR? |
|
The branch needs just a quick rebase and it's fine! Awesome work! |
Changed the ini syntax on how to specify custom positions. Now the number of custom positions is no more hardcoded. If no custom positions are defined in the ini file, no custom positions options are created in the Menu. Instead, a submenu option is created and populated with the correct number of custom positions. Added also menu option for the custom positons in the single part menubar. Additionally, now the custom positions are named, so it is easier in the GUI to find and launch the correct custom positions when more than one is specified in the ini
Only the first 9 custom positions have associated shortcuts (numbered from 1 to 9) To command a global (all joints) position the shortcut is CTRL + META + [num] For a single part the ALT modified must be added
francesco-romano
force-pushed
the
motorgui
branch
from
6b0a946
to
7b84461
Compare
|
@randaz81 rebase done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed custom positions support in the motorgui.
To implement this change I needed to change the .ini syntax regarding the custom positions (which was anyway new and never pushed to master).
The proposed changes have the following impact on the use of the motorgui:
For @robotology/codyco-developers this means that it is now possible to have a single ini file with the most often used configurations.
See this screenshots for an example:
Updated also release notes and changed the
yarpmotorguidoxygen documentation section regarding the home position to document the new .ini syntaxcc @randaz81
cc @DanielePucci @gabrielenava @traversaro