Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for D405 #40

Merged
merged 4 commits into from
May 29, 2023
Merged

Add support for D405 #40

merged 4 commits into from
May 29, 2023

Conversation

xEnVrE
Copy link
Contributor

@xEnVrE xEnVrE commented Mar 21, 2023

This makes some modifications to realsense2Driver::initializeRealsenseDevice(), realsense2Driver::setDepthResolution() and realsense2Driver::setRgbResolution() so that the D405 camera is supported.

The changes to realsense2Driver::setRgbResolution() and realsense2Driver::setDepthResolution() are probably desirable independently from the D405 as these methods should only change the configuration for the part they compete to, i.e. color and depth parameters respectively.

Fixes #39

cc @randaz81 @traversaro

@xEnVrE xEnVrE requested a review from Nicogene as a code owner March 21, 2023 09:44
@xEnVrE xEnVrE marked this pull request as draft March 21, 2023 09:44
@xEnVrE
Copy link
Contributor Author

xEnVrE commented Mar 21, 2023

The PR has been converted to a draft as I would like to discuss the changes with @randaz81 first.

@xEnVrE xEnVrE mentioned this pull request Mar 21, 2023
@xEnVrE
Copy link
Contributor Author

xEnVrE commented May 9, 2023

Given the tests we have done and considering IntelRealSense/librealsense#11784, I have decided to add a specific section in the README.md explaining how to properly configure the ini file to run the D405 camera.

@xEnVrE
Copy link
Contributor Author

xEnVrE commented May 12, 2023

After the code review I made f2f also with @randaz81, we decided it was better to make more explicit the section with the exceptions for the D405 at the cost to have a bit more redundant code but more readable.

I pushed the changes.

A part from this, I am going to test the device after these changes with all the cameras we have next week and then I'll mark the PR as ready.

cc @Nicogene

@xEnVrE
Copy link
Contributor Author

xEnVrE commented May 22, 2023

I tested the device with this PR changes, by visualizing both RGB and depth, on yarpview on the following devices:

  • RealSense D455
  • RealSense D435
  • RealSense D435i
  • RealSense D405
  • RealSense D415
  • RealSense L515

Hence, I am marking this PR as ready.

@xEnVrE xEnVrE marked this pull request as ready for review May 22, 2023 15:49
@xEnVrE xEnVrE requested a review from Nicogene May 22, 2023 15:50
@randaz81 randaz81 merged commit 385a36a into robotology:master May 29, 2023
@traversaro
Copy link
Member

Sorry @xEnVrE, I forgot this. Can you add a line to the CHANGELOG.md for this change? Thanks! So we can do a release with this change.

@xEnVrE xEnVrE deleted the impl/d405 branch May 29, 2023 22:26
@xEnVrE xEnVrE mentioned this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the RealSense D405
4 participants