Fix wrong coefficients coupling the eyes' vergence #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Thanks heaps @martinaxgloria!
What I found a bit puzzling is how we handle the coupling for those old CAN robots that we still maintain, such as iCubNancy01. It doesn't seem to have this info in its folders.
|
Yes, @pattacini. I noticed that those robots don't have this kind of information in the configuration files, so I skipped them because I didn't find the references anywhere. Maybe @davidetome could have the answer |
|
Checked w/ @davidetome @Nicogene and finally @maggia80 👍🏻 |
|
Great, thank you all! |
MSECode
pushed a commit
to valegagge/robots-configuration
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #228.
I did some tests on
iCubGenova11with this change and I posted here the results. Then, I proceeded with the update of the other maintained robots.